Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #257
This PR updates Scalar to the latest version as of today, 1.44.27. This should fix the type issues people were seeing. The latest Scalar dist was downloaded from https://www.jsdelivr.com/package/npm/@scalar/api-reference.
In the Scalar config, I moved the url property to top-level to match the latest schema. I also disabled the new AI feature by default.
An alternative solution would be to load the latest version of Scalar dynamically (something like this) so updates are no longer needed. Happy to update PR if you want go in that direction.
Screenshots
Tested with the Axum example:
Before: TodoItem is labeled AppError
After: TodoItem labeled correctly
