Skip to content

VAnchor Substrate Implementation (Missing Withdraw/Transfer Flows)#1139

Merged
dutterbutter merged 97 commits into
developfrom
trung-tin/vanchor-substrate-imple
May 3, 2023
Merged

VAnchor Substrate Implementation (Missing Withdraw/Transfer Flows)#1139
dutterbutter merged 97 commits into
developfrom
trung-tin/vanchor-substrate-imple

Conversation

@AtelyPham
Copy link
Copy Markdown
Contributor

@AtelyPham AtelyPham commented Apr 24, 2023

Summary of changes

  • Adding scripts to setup the local tangle and protocol-substrate environments for testing.
  • Fetching currency info on Substrate.
  • Implement the deposit flow (currently got a bug).
  • Iterate some flows to work on both evm and substrate (getNextIndex, getLeafIndex, ...).
  • ...

Scripts added

  • yarn nx run bridge-dapp:run-local-substrate: Run and setup the environment for local protocol-substrate (read info here before running the script).

How to setup and test Substrate <> Substrate deposit flow

  • Clone and build: https://github.com/webb-tools/protocol-substrate.
    • Note: Please put the protocol-substrate repo in the same level as the webb-dapp repo in your machine.
  • Start the local substrate by using yarn nx run bridge-dapp:run-local-substrate on your terminal.
  • Wait until ✅ Protocol Substrate ready to use!!! message shows on the terminal.
  • Start the bridge in a new terminal.
  • Open your browser at http://localhost:3000 and select the Substrate chain in the chain selection card
    • Choose the development option
  • You are ready to transact on protocol-substrate.

Proposed area of change

  • apps/bridge-dapp
  • apps/stats-dapp
  • apps/webbsite
  • apps/faucet
  • apps/tangle-website
  • libs/webb-ui-components

Reference issue to close (if applicable)

  • Closes NaN

Screen Recording

CleanShot.2023-04-29.at.03.11.01.mp4

AtelyPham and others added 30 commits March 11, 2023 01:11
@AtelyPham AtelyPham marked this pull request as ready for review May 2, 2023 18:25
@AtelyPham AtelyPham requested a review from drewstone May 2, 2023 18:25
@AtelyPham AtelyPham changed the title VAnchor Substrate Implementation VAnchor Substrate Implementation (Missing Withdraw/Transfer Flows) May 2, 2023
new Worker(
new URL(
'@webb-tools/react-environment/arkworks-proving-manager.worker'
'@webb-tools/react-environment/arkworks-proving-manager.worker',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also consider having a way to test out using the same flow for Circom proving (for EVM) on the Substrate side as well. We do have a test showing that those proofs are valid. Possible new task.

Copy link
Copy Markdown
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, big change here. Granted we want to use Circom proving for all sides of the bridge, that is my main feedback here. We should create a new task to use the same proving pipeline for any side, and work to deprecate the WASM/Web Worker pattern in favor for what's already on the EVM sides.

@dutterbutter
Copy link
Copy Markdown
Contributor

@AtelyPham please resolve conflict

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2023

Deploy Preview for stats-dapp development is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 957a4d197a81fdcc0625c8221eaf819a00db7694
🔍 Latest deploy log https://app.netlify.com/sites/development-stats/deploys/64515c10fe12e231630c162b
😎 Deploy Preview https://64515c10fe12e231630c162b--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2023

Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 957a4d197a81fdcc0625c8221eaf819a00db7694
🔍 Latest deploy log https://app.netlify.com/sites/development-hubble-bridge/deploys/64515c5a6dc7d83115b38eac
😎 Deploy Preview https://64515c5a6dc7d83115b38eac--development-hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2023

Deploy Preview for webb faucet is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 957a4d197a81fdcc0625c8221eaf819a00db7694
🔍 Latest deploy log https://app.netlify.com/sites/webb-faucet/deploys/64515cc0bef90734eb09d479
😎 Deploy Preview https://64515cc0bef90734eb09d479--webb-faucet.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2023

Deploy Preview for stats-dapp development is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 5ee9feccb5c12c1ced73658a10bb51b3141d42a4
🔍 Latest deploy log https://app.netlify.com/sites/development-stats/deploys/645276dd00f7372c946b70b7
😎 Deploy Preview https://645276dd00f7372c946b70b7--development-stats.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2023

Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 5ee9feccb5c12c1ced73658a10bb51b3141d42a4
🔍 Latest deploy log https://app.netlify.com/sites/development-hubble-bridge/deploys/6452774f6f424724d3667843
😎 Deploy Preview https://6452774f6f424724d3667843--development-hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2023

Deploy Preview for webb faucet is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 5ee9feccb5c12c1ced73658a10bb51b3141d42a4
🔍 Latest deploy log https://app.netlify.com/sites/webb-faucet/deploys/645277d6891bdf1f274df38a
😎 Deploy Preview https://645277d6891bdf1f274df38a--webb-faucet.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@dutterbutter dutterbutter merged commit 72a773b into develop May 3, 2023
@dutterbutter dutterbutter deleted the trung-tin/vanchor-substrate-imple branch May 3, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed ✅

Development

Successfully merging this pull request may close these issues.

5 participants