Skip to content

Update Tangle according audit/review#1175

Merged
dutterbutter merged 15 commits into
developfrom
tuan-linh/tangle-review-audit
May 11, 2023
Merged

Update Tangle according audit/review#1175
dutterbutter merged 15 commits into
developfrom
tuan-linh/tangle-review-audit

Conversation

@vutuanlinh2k2
Copy link
Copy Markdown
Contributor

@vutuanlinh2k2 vutuanlinh2k2 commented May 9, 2023

Summary of changes

Update the Tangle Website according audit/review

Proposed area of change

Put an x in the boxes that apply.

  • apps/bridge-dapp
  • apps/stats-dapp
  • apps/webbsite
  • apps/faucet
  • apps/tangle-website
  • libs/webb-ui-components

Reference issue to close (if applicable)

Closes #1137

Screen Recording

If possible provide a screen recording of proposed change.


Code Checklist

Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@github-actions

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2023

Deploy Preview for tangle website is ready! Thanks for the contribution @dutterbutter

Name Link
🔨 Latest commit 8f1ec59fc4c7e9ce595ace09c4b6baaf23b0cc24
🔍 Latest deploy log https://app.netlify.com/sites/tangle-webbsite/deploys/645aab8640af033406fa5002
😎 Deploy Preview https://645aab8640af033406fa5002--tangle-webbsite.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Copy Markdown
Contributor

@AtelyPham AtelyPham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGMT ✅ Please wait for @monaiuu and @thomivy to review the UI updates and copies before merging.

@AtelyPham AtelyPham requested review from monaiuu and thomivy May 10, 2023 14:29
@monaiuu
Copy link
Copy Markdown
Contributor

monaiuu commented May 10, 2023

Thanks for the quick updates!! Margins for hero section LGTM!

Found a few more UI updates that'll be nice to include before merging:

Screenshot 2023-05-10 at 8 10 32 AM
  • Hero image becomes distorted between ~1440px -> 1024px
Screenshot 2023-05-10 at 8 32 09 AM
  • Remove the shadow behind the annotation component
  • Add hover state to the annotation component when the tooltips open
Screenshot 2023-05-10 at 8 13 12 AM
  • Features section cards images become distorted going into smaller breakpoints (under 768px)

@github-actions
Copy link
Copy Markdown

Deploy Preview for tangle website is ready! Thanks for the contribution @dutterbutter

Name Link
🔨 Latest commit 4b6c09e0e92d9d747618a2749af2c90fa1c6be91
🔍 Latest deploy log https://app.netlify.com/sites/tangle-webbsite/deploys/645bbcf11d8aba0ae306830d
😎 Deploy Preview https://645bbcf11d8aba0ae306830d--tangle-webbsite.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown

Deploy Preview for tangle website is ready! Thanks for the contribution @dutterbutter

Name Link
🔨 Latest commit af3d2f12bcd59cc8fc3d3847114d184511d8d26c
🔍 Latest deploy log https://app.netlify.com/sites/tangle-webbsite/deploys/645bf45d7c80230ec80a51ac
😎 Deploy Preview https://645bf45d7c80230ec80a51ac--tangle-webbsite.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@dutterbutter
Copy link
Copy Markdown
Contributor

@vutuanlinh2k2 please address changes requested here: #1175 (comment)

@github-actions
Copy link
Copy Markdown

Deploy Preview for tangle website is ready! Thanks for the contribution @vutuanlinh2k2

Name Link
🔨 Latest commit e7b0462f2879fb25c959915aff7e8116ebc56088
🔍 Latest deploy log https://app.netlify.com/sites/tangle-webbsite/deploys/645c62f5550a2446c9488c00
😎 Deploy Preview https://645c62f5550a2446c9488c00--tangle-webbsite.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown

Deploy Preview for tangle website is ready! Thanks for the contribution @dutterbutter

Name Link
🔨 Latest commit 438c4e1582613e7832bc46d3d1ef22fd31eae316
🔍 Latest deploy log https://app.netlify.com/sites/tangle-webbsite/deploys/645cebc168616d0f54fbb938
😎 Deploy Preview https://645cebc168616d0f54fbb938--tangle-webbsite.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

@dutterbutter dutterbutter merged commit 89f54d2 into develop May 11, 2023
@dutterbutter dutterbutter deleted the tuan-linh/tangle-review-audit branch May 11, 2023 13:47
@thomivy
Copy link
Copy Markdown
Contributor

thomivy commented May 11, 2023

General:

  • Remove or otherwise disable crowdloan purple banner. (May need in future)
Screenshot 2023-05-11 at 10 58 44 AM Note for @monaiuu , we're not using folds super well. Modules are taller than fits in single screen heights, and so scrolling is awkward and breaks up information that should otherwise be seen as a complete module.

The TSS section is interesting, we should give it its own explanatory section with several benefits, a quick draft of that text would look like this:

TSS
Enhance your digital security with threshold signature schemes. Say goodbye to single points of failure and key compromises. With distributed signing authority, your assets remain protected against unauthorized access and insider attacks.

Resilience in Adversity:
Safeguard your operations with threshold signatures. Even if some participants are unavailable or act maliciously, a sufficient threshold ensures secure signing. Trust that your critical applications will continue to function smoothly.

Preserve Your Privacy: 
Protect sensitive information with threshold signature schemes. Your signing authority is separate from individual signers, ensuring privacy. Transact confidently without compromising personal data.

Scale with Confidence: 
Unlock scalability and availability in distributed systems. Leverage the combined power of multiple entities. With a threshold of participants, your system can handle increased demands while ensuring availability.

Minimize Trust, Maximize Control: 
Reduce dependence on trust with threshold signatures. Distribute signing authority to minimize risks. Maintain control over your digital world with confidence.
Screenshot 2023-05-11 at 11 05 17 AM Remove the highlighted text. Screenshot 2023-05-11 at 11 06 05 AM
  • Remove the highlighted text.
  • Additionally, would be good to re-balance icon sizing and spacing for this section. Lots of negative space in the Icon. ICon should probably sit left of the header text rather than on new line.
  • Change use case text:
General Messaging Passing & Public Bridges: 
Seamlessly facilitate public and transparent cross-chain interactions. Experience unparalleled efficiency and security through a dynamic TSS-based system, where multiple participants collaborate harmoniously.

Connected Shielded Pool Protocols: 
Unleash the true potential of interconnected ecosystems to empower private movement and the seamless transfer of assets between blockchains. Unleash the true potential of interconnected ecosystems.

Connected Shielded Identity Protocols: 
Harness the revolutionary privacy of the Network to forge identities and establish meaningful connections between diverse blockchains. Bridge the gaps and unite digital realms like never before.

Oracle System and Data Feeds: 
Empower financial, identity, and other applications with trustworthy information through the next-gen Webb DKG (Distributed Key Generation) to securely sign payloads from data feeds. 
Screenshot 2023-05-11 at 11 18 47 AM
  • The bulletpoints are not being rendered here.
Screenshot 2023-05-11 at 11 19 29 AM
  • Remove the highlighted text.
Screenshot 2023-05-11 at 11 19 53 AM
  • Remove this text at footer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CHECKLIST] Review/audit Tangle website UI and copy

5 participants