Adds token to Metamask - Faucet App#1186
Merged
Merged
Conversation
|
✅ Deploy Preview for webb faucet is ready! Thanks for the contribution @devpavan04
To edit notification comments on pull requests, go to your Netlify site settings. |
AtelyPham
approved these changes
May 10, 2023
Contributor
AtelyPham
left a comment
AtelyPham
left a comment
There was a problem hiding this comment.
Left a comment, otherwise LGTM!
|
|
||
| console.log('Token added to Metamask'); | ||
| } catch (error) { | ||
| console.error(error); |
Contributor
There was a problem hiding this comment.
If the token is added to Metamask already, the provider.request will throw an error or warning I'm pretty sure but we should somehow notify the user about that, we could do that in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add token to Metamaskbutton.Proposed area of change
apps/bridge-dappapps/stats-dappapps/webbsiteapps/faucetapps/tangle-websitelibs/webb-ui-componentsReference issue to close (if applicable)
Screen Recording
CleanShot.2023-05-09.at.19.25.32.mp4