Skip to content

Hot Fixes #2 for the Bridge#1198

Merged
AtelyPham merged 2 commits into
developfrom
trung-tin/hot-fixes-1
May 11, 2023
Merged

Hot Fixes #2 for the Bridge#1198
AtelyPham merged 2 commits into
developfrom
trung-tin/hot-fixes-1

Conversation

@AtelyPham
Copy link
Copy Markdown
Contributor

Summary of changes

  • Fix: fee should be 0 when no relayer is selected, so the contract won't transfer the fee to zeroAddress.
  • Renaming variables in the transfer file for more clarity.

Proposed area of change

  • apps/bridge-dapp
  • apps/stats-dapp
  • apps/webbsite
  • apps/faucet
  • apps/tangle-website
  • libs/webb-ui-components

Reference issue to close (if applicable)

Screenshots

image

@AtelyPham AtelyPham requested a review from dutterbutter May 11, 2023 19:57
@AtelyPham AtelyPham self-assigned this May 11, 2023
@AtelyPham AtelyPham changed the title Hot Fixes for the Bridge Hot Fixes #2 for the Bridge May 11, 2023
@AtelyPham AtelyPham merged commit 538fd88 into develop May 11, 2023
@AtelyPham AtelyPham deleted the trung-tin/hot-fixes-1 branch May 11, 2023 20:07
@github-actions
Copy link
Copy Markdown

Deploy Preview for bridge-dapp development is ready! Thanks for the contribution @AtelyPham

Name Link
🔨 Latest commit 387a0a15f9671296b95b11a14bc342efb426915d
🔍 Latest deploy log https://app.netlify.com/sites/development-hubble-bridge/deploys/645d4d2c623fff08afd4a251
😎 Deploy Preview https://645d4d2c623fff08afd4a251--development-hubble-bridge.netlify.app

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed ✅

Development

Successfully merging this pull request may close these issues.

[BUG] execution reverted: ERC20: transfer to the zero address on Hubble Withdrawal

2 participants