Skip to content

fix(tangle-dapp): Fix network switch glitch in Liquid Staking page#2671

Merged
drewstone merged 1 commit into
developfrom
yuri/fix-ls-network-switch-glitch
Nov 25, 2024
Merged

fix(tangle-dapp): Fix network switch glitch in Liquid Staking page#2671
drewstone merged 1 commit into
developfrom
yuri/fix-ls-network-switch-glitch

Conversation

@yuri-xyz
Copy link
Copy Markdown
Contributor

@yuri-xyz yuri-xyz commented Nov 25, 2024

Summary of changes

Provide a detailed description of proposed changes.

  • 🐛 Fixed a bug that caused multiple network switches when changing networks within the liquid staking page.
  • 🔧 Removed URL search param sync functionality as it is making things complex with not much benefit.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/tangle-shared-ui
  • libs/webb-ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide screenshots and/or a screen recording of proposed change.

@yuri-xyz yuri-xyz self-assigned this Nov 25, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 25, 2024

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit c47c5ad
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/6744fad2ca6f640008d3be35
😎 Deploy Preview https://deploy-preview-2671--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 25, 2024

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit c47c5ad
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/6744fad2821847000834d7a1
😎 Deploy Preview https://deploy-preview-2671--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yuri-xyz yuri-xyz marked this pull request as ready for review November 25, 2024 23:26
@drewstone drewstone merged commit e763e65 into develop Nov 25, 2024
@drewstone drewstone deleted the yuri/fix-ls-network-switch-glitch branch November 25, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed ✅

Development

Successfully merging this pull request may close these issues.

[BUG] Network switch triggers multiple connections

2 participants