refactor: WP-876 customize tenant UI via config#106
Open
wesleyboar wants to merge 6 commits intotapis-project:devfrom
Open
refactor: WP-876 customize tenant UI via config#106wesleyboar wants to merge 6 commits intotapis-project:devfrom
wesleyboar wants to merge 6 commits intotapis-project:devfrom
Conversation
wesleyboar
commented
Feb 20, 2025
Contributor
Author
wesleyboar
left a comment
wesleyboar
left a comment
There was a problem hiding this comment.
There is Python code (not my specialty) by AI; please scrutinize. I also created a data structure that deserves an evaluation. The template code should be tested. I would if I could.
Comment on lines
+24
to
+27
| @app.context_processor | ||
| def inject_tenant_ui_config(): | ||
| return {'tenant_ui_config': TENANT_UI_CONFIG} | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Warning
Code provided by AI and is untested.
Contributor
Author
There was a problem hiding this comment.
Note
👋 Opinions welcome. Naming? Structure? Location? Import?
NotChristianGarcia
force-pushed
the
dev
branch
from
d9e1288 to
ea3308b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Customize UI per tenant via config instead of many if/else statements.
Related
Changes
api.pyconfigs.pybranding.htmlto use UI config contextlogin.htmlto use UI config contextTesting
/apcd/in "Create Account" urlUI
I can not test. My environment fails. I requested help.