⚠️ enhance: WP-308 form footer "Powered by: [tapis]" — 2nd try#62
Draft
wesleyboar wants to merge 2 commits intotapis-project:devfrom
Draft
Conversation
…owered-by-tapis-in-footer enhance: WP-308 form footer "Powered by: [tapis]"
wesleyboar
commented
Oct 4, 2023
Comment on lines
+15
to
+23
| {% block head_extra %} | ||
| {{ super() }} | ||
| <style> | ||
| /* To move non-image links to the left */ | ||
| .powered_by { | ||
| margin-left: auto; | ||
| } | ||
| </style> | ||
| {% endblock %} |
Contributor
Author
There was a problem hiding this comment.
Warning
This causes crash. See #61 for details.
This was referenced Oct 4, 2023
Contributor
Author
|
Note This PR is still relevant. I track it in CMD-56. |
NotChristianGarcia
force-pushed
the
dev
branch
from
d9e1288 to
ea3308b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add "Powered by: [tapis]" to form footer. Update Core-Styles version.
Caution
Do not merge. Crashes! See #61.
Related
WP-308CMD-56Changes
Testing
UI
Note
I could not render every form, because I tested in situ.
Update: As of 2024-07-18, I can test locally.