Skip to content

🔧 chore(deps): bump pnpm#19

Merged
xdanger merged 1 commit into
mainfrom
codex/dependency-sweep-20260515
May 15, 2026
Merged

🔧 chore(deps): bump pnpm#19
xdanger merged 1 commit into
mainfrom
codex/dependency-sweep-20260515

Conversation

@xdanger
Copy link
Copy Markdown
Member

@xdanger xdanger commented May 15, 2026

Summary\n- Bump the Corepack pnpm pin from 10.33.4 to 11.1.2.\n\n## Validation\n- pnpm install --frozen-lockfile\n- pnpm outdated --format json => {}\n- pnpm run lint\n\n## Risk\n- pnpm 11 requires Node >=22.13; this repo does not declare a stricter Node engine.

- 🔧 align Corepack pin with current pnpm release
@claude
Copy link
Copy Markdown

claude Bot commented May 15, 2026

✅ Approved

No new issues found. This is a clean, single-line bump of the Corepack pnpm pin from 10.33.4 → 11.1.2.

Notes:

  • Lockfile is already v9.0, compatible with pnpm 11 — no lockfile format migration needed.
  • The Node ≥22.13 requirement (called out in the PR description) is consistent with existing dependency engine constraints already present in pnpm-lock.yaml.
  • Repo scripts (lint, format, prepare) use no pnpm-10-specific features affected by breaking changes in v11.

LGTM.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 15, 2026

Greptile Summary

package.json 中的 Corepack pnpm pin 从 10.33.4 升级到 11.1.2,并更新了对应的 SHA-512 完整性哈希。

  • pnpm 版本升级packageManager 字段从 pnpm@10.33.4 更新为 pnpm@11.1.2,SHA 哈希同步更新;pnpm-lock.yaml 保持 lockfile v9.0 格式不变,与 pnpm 11 向后兼容。
  • Node.js 要求变化:pnpm 11 放弃了对 Node.js 18 和 20 的支持,要求 Node.js >= 22.13;该约束目前未通过 engines 字段在 manifest 中显式声明。

Confidence Score: 4/5

这是一次干净的 pnpm 主版本升级,SHA 哈希已更新,锁文件格式向后兼容,PR 作者已在本地完成了 frozen-lockfile 验证。

唯一需要关注的点是 pnpm 11 引入了 Node.js >= 22 的硬性要求,但 package.json 中缺少 engines 字段来明确声明这一约束,可能导致使用 Node 18/20 的开发者遇到不直观的错误。

package.json — 建议补充 engines 字段以明确记录 Node.js >= 22.13 的运行时要求。

Important Files Changed

Filename Overview
package.json 将 pnpm 从 10.33.4 升级到 11.1.2,并更新了 SHA-512 校验哈希;缺少 engines 字段来声明 pnpm 11 引入的 Node.js >= 22 要求。

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Developer runs pnpm command] --> B{Corepack checks packageManager field}
    B --> C[pnpm 11.1.2 SHA verified]
    C --> D{Node.js version check}
    D -->|Node 22+| E[OK - pnpm 11 supported]
    D -->|Node 18 or 20| F[ERROR - unsupported Node version]
    E --> G[pnpm install frozen-lockfile]
    G --> H[lockfile v9.0 read compatible]
    H --> I[Dependencies installed]
Loading

Fix All in Codex Fix All in Claude Code

Reviews (1): Last reviewed commit: "🔧 chore(deps): bump pnpm" | Re-trigger Greptile

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the repository’s Corepack packageManager pin to pnpm 11.1.2, updating the toolchain version used for installs and scripts.

Changes:

  • Update packageManager in package.json from pnpm 10.33.4 to pnpm 11.1.2 (Corepack pin).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
@@ -1,5 +1,5 @@
{
"packageManager": "pnpm@10.33.4+sha512.1c67b3b359b2d408119ba1ed289f34b8fc3c6873412bec6fd264fbdc82489e510fcbecb9ce9d22dae7f3b76269d8441046014bdca53b9979cd7a561ad631b800",
"packageManager": "pnpm@11.1.2+sha512.415a1cc25974731e75455c1468371be74c5aa5fb7621b50d4056d222451609f11412f23fd602e6169f1e060466641f798597e1be961a10688836a67b16569499",
Comment thread package.json
@@ -1,5 +1,5 @@
{
"packageManager": "pnpm@10.33.4+sha512.1c67b3b359b2d408119ba1ed289f34b8fc3c6873412bec6fd264fbdc82489e510fcbecb9ce9d22dae7f3b76269d8441046014bdca53b9979cd7a561ad631b800",
"packageManager": "pnpm@11.1.2+sha512.415a1cc25974731e75455c1468371be74c5aa5fb7621b50d4056d222451609f11412f23fd602e6169f1e060466641f798597e1be961a10688836a67b16569499",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 pnpm 11 要求 Node.js >= 22(放弃对 Node 18/20 的支持),但 package.json 中没有 engines 字段来声明这个约束。使用 Node 18 或 20 的开发者在 Corepack 激活后会遇到不清晰的错误,而不是明确的版本不兼容提示。PR 描述中已经提到了这个风险,建议在 manifest 中显式记录。

Suggested change
"packageManager": "pnpm@11.1.2+sha512.415a1cc25974731e75455c1468371be74c5aa5fb7621b50d4056d222451609f11412f23fd602e6169f1e060466641f798597e1be961a10688836a67b16569499",
"packageManager": "pnpm@11.1.2+sha512.415a1cc25974731e75455c1468371be74c5aa5fb7621b50d4056d222451609f11412f23fd602e6169f1e060466641f798597e1be961a10688836a67b16569499",
"engines": {
"node": ">=22.13"
},

Fix in Codex Fix in Claude Code

@xdanger xdanger merged commit 6de5598 into main May 15, 2026
9 checks passed
@xdanger xdanger deleted the codex/dependency-sweep-20260515 branch May 15, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants