New debian release - #5256
Conversation
Totktonada
left a comment
Totktonada
left a comment
There was a problem hiding this comment.
Thank you for the PR! Please, consider several comments below.
I would also appreciate if you'll prefix the commit header with build prefix. It eases navigation over the git history.
BTW, can you give some suggestions how we can keep tarantool more or less up-to-date in exisitng Debian releases?
| dh-systemd (>= 1.22) | sysvinit (<< 2.88dsf-59) | upstart (<< 1.13), | ||
| Build-Depends: | ||
| cdbs (>= 0.4.100), | ||
| debhelper (>= 9.2), |
There was a problem hiding this comment.
Should not it be >= 9.20160709 (according to #958615)? It seems, it'll break our build for Debian Jessie, but it is EOL and maybe this is good time to drop its support. Debian Stretch has debhelper-10.2.5.
|
|
||
| *.dll | ||
| *.exe |
There was a problem hiding this comment.
Those files are not generated during build or testing, so I don't see a reason to place them to gitignore. Excluding them from tarballs should be enough to fix the lintian warning.
| @@ -1,3 +1,13 @@ | |||
| tarantool (2.6.0-1) unstable; urgency=medium | |||
There was a problem hiding this comment.
It is better to publish a stable (x.y.z where z >= 2, 2.4.2 ATM) or at least a beta (z.y.1, 2.5.1 ATM) release. x.y.0 is alpha. However x.y.0.0 is practically same as x.(y-1).1.0. (We're working on the relevant documentation.)
Anyway, I see that you already pushed 2.6.0-0-g47aa4e01e to Debian Sid, so it is just note for future updates.
| Build-Depends: cdbs (>= 0.4.100), debhelper (>= 9), dpkg-dev (>= 1.16.1~), | ||
| # Enable systemd for Debian Jessie+ and Ubuntu Wily+ | ||
| dh-systemd (>= 1.22) | sysvinit (<< 2.88dsf-59) | upstart (<< 1.13), | ||
| Build-Depends: |
| UVERSION := $(shell echo $(VERSION)|sed 's/-[[:digit:]]\+$$//') | ||
|
|
||
| ifneq ($(wildcard /usr/bin/dh_systemd_start),) | ||
| ifeq ($(INIT_VARIANT),systemd) |
There was a problem hiding this comment.
Maybe now is good time to just enable it unconditionally. All Debian and Ubuntu distros, which offers something else by default, already gone.
|
No reaction from submitter for more than 3 months. |
|
Anyway I'll extract the proposed enhancements in a non-breaking way when time will permit. |
|
NB: The debhelper version was bumped in PR #5638. We still need to look / verify / describe the remaining changes that are proposed here. |
3 participants
Hi!
I've just uploaded 2.6 to Debian and did some changes (actual debian infrastructure)
Please check it