Skip to content

refactor: address nolint feedback #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wass3r merged 1 commit into from
Aug 19, 2022
Merged

refactor: address nolint feedback #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ linters-settings:

# https://github.com/golangci/golangci-lint/blob/master/pkg/golinters/nolintlint
nolintlint:
allow-leading-space: true # allow non-"machine-readable" format (ie. with leading space)
allow-unused: false # allow nolint directives that don't address a linting issue
require-explanation: true # require an explanation for nolint directives
require-specific: true # require nolint directives to be specific about which linter is being skipped
Expand Down
8 changes: 4 additions & 4 deletions core/configure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func configureChatApplication(bot *models.Bot) {

if bot.ChatApplication != "" {
switch strings.ToLower(bot.ChatApplication) {
// nolint:goconst // refactor
//nolint:goconst // refactor
case "discord":
// Discord bot token
token, err := utils.Substitute(bot.DiscordToken, emptyMap)
Expand Down Expand Up @@ -74,11 +74,11 @@ func configureChatApplication(bot *models.Bot) {
bot.RunChat = false
}

// nolint:goconst // refactor
//nolint:goconst // refactor
case "slack":
configureSlackBot(bot)

// nolint:goconst // refactor
//nolint:goconst // refactor
case "telegram":
token, err := utils.Substitute(bot.TelegramToken, emptyMap)
if err != nil {
Expand All @@ -95,7 +95,7 @@ func configureChatApplication(bot *models.Bot) {

bot.TelegramToken = token

// nolint:goconst // refactor
//nolint:goconst // refactor
case "google_chat":
gchat.Configure(bot)

Expand Down
2 changes: 1 addition & 1 deletion core/matcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func getProccessedInputAndHitValue(messageInput, ruleRespondValue, ruleHearValue
}

// handleChatServiceRule handles the processing logic for a rule that came from either the chat application or CLI remote.
// nolint:gocyclo // refactor candidate
//nolint:gocyclo // refactor candidate
func handleChatServiceRule(outputMsgs chan<- models.Message, message models.Message, hitRule chan<- models.Rule, rule models.Rule, processedInput string, hit bool, bot *models.Bot) (bool, bool) {
match, stopSearch := false, false

Expand Down
2 changes: 1 addition & 1 deletion handlers/script.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func ScriptExec(args models.Action, msg *models.Message) (*models.ScriptResponse
bin := utils.ExecArgTokenizer(cmdProcessed)

// prep the command to be executed with context
// nolint:gosec // ignore "potential tainted input or cmd arguments" because bot owner controls usage
//nolint:gosec // ignore "potential tainted input or cmd arguments" because bot owner controls usage
cmd := exec.CommandContext(ctx, bin[0], bin[1:]...)

// run command and capture stdout/stderr
Expand Down
2 changes: 1 addition & 1 deletion remote/slack/helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,7 @@ func readFromEventsAPI(api *slack.Client, vToken string, inputMsgs chan<- models
// readFromSocketMode reads messages from Slack's Socket Mode
//
// https://api.slack.com/apis/connections/socket
// nolint:gocyclo,funlen // needs refactor
//nolint:gocyclo,funlen // needs refactor
func readFromSocketMode(sm *slack.Client, inputMsgs chan<- models.Message, bot *models.Bot) {
// setup the client
client := socketmode.New(sm)
Expand Down