-
Notifications
You must be signed in to change notification settings - Fork 0
add thread content search command #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tarik02
wants to merge
1
commit into
master
Choose a base branch
from
feat/thread-content-search
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "t3code-cli": patch | ||
| --- | ||
|
|
||
| add conversation content search command |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import * as Effect from "effect/Effect"; | ||
| import * as Option from "effect/Option"; | ||
| import { Argument, Command, Flag } from "effect/unstable/cli"; | ||
|
|
||
| import { T3Application } from "../application/service.ts"; | ||
| import { loadT3CliEnv } from "../config/env/env.ts"; | ||
| import { InvalidLimitError } from "./error.ts"; | ||
| import { extraArgsConfig } from "./extra-args.ts"; | ||
| import { formatFlag } from "./flags.ts"; | ||
| import { formatThreadSearchHuman } from "./format/thread.ts"; | ||
| import { resolveOutputFormat } from "./format/output.ts"; | ||
| import { T3Output } from "./output/service.ts"; | ||
| import { CliRuntime } from "./runtime/service.ts"; | ||
|
|
||
| export const searchThreadsCommand = Command.make( | ||
| "search", | ||
| { | ||
| query: Argument.string("query"), | ||
| limit: Flag.integer("limit").pipe( | ||
| Flag.withDescription("Maximum matches (1-50, default: 50)"), | ||
| Flag.optional, | ||
| ), | ||
| format: formatFlag, | ||
| ...extraArgsConfig, | ||
| }, | ||
| ({ query, limit, format }) => | ||
| Effect.gen(function* () { | ||
| const value = Option.getOrUndefined(limit); | ||
| if (value !== undefined && (value < 1 || value > 50)) { | ||
| return yield* Effect.fail( | ||
| new InvalidLimitError({ message: `invalid limit: ${value}`, value: String(value) }), | ||
| ); | ||
| } | ||
| const application = yield* T3Application; | ||
| const cliRuntime = yield* CliRuntime; | ||
| const t3CliEnv = yield* loadT3CliEnv; | ||
| const output = yield* T3Output; | ||
| const resolvedFormat = resolveOutputFormat(format, cliRuntime, t3CliEnv, "json"); | ||
| const matches = yield* application.searchThreads({ | ||
| query, | ||
| ...(value !== undefined ? { limit: value } : {}), | ||
| }); | ||
| if (resolvedFormat === "json") { | ||
| return yield* output.printJson(matches); | ||
| } | ||
| return yield* output.writeStdout(formatThreadSearchHuman(matches)); | ||
| }), | ||
| ).pipe(Command.withDescription("search threads by conversation content")); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule upstream-t3code
updated
138 files
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a search match belongs to an archived thread,
getShellSnapshot()cannot supply its shell metadata because this repository explicitly loads archived threads throughgetArchivedShellSnapshot()(seeloadThreadsSnapshot). Consequently, valid matches are returned withthreadTitle,branch, andworktreePathset tonull, and human output displays-for those fields. Enrich search matches from a merged active-and-archived snapshot instead.Useful? React with 👍 / 👎.