Skip to content

support preview annotations and automation in iframes#67

Open
tarik02 wants to merge 5 commits into
mainfrom
feat/preview-iframe-support
Open

support preview annotations and automation in iframes#67
tarik02 wants to merge 5 commits into
mainfrom
feat/preview-iframe-support

Conversation

@tarik02

@tarik02 tarik02 commented Jul 19, 2026

Copy link
Copy Markdown
Owner

What Changed

  • Run the existing preview annotation preload in every frame.
  • Render annotation outlines inside their owning frame while the main frame keeps the toolbar and editor.
  • Relay nested-frame annotation state through parent frames with postMessage, including coordinate projection and clipping.
  • Traverse Electron WebFrameMain.framesInSubtree directly for preview snapshots and MCP actions.
  • Expose frameIndex for explicit frame targeting while selector actions search all frames by default.

Why

Preview stopped at iframe boundaries. Selection, regions, annotations, and MCP actions only worked in the main document.

This keeps iframe support inside the existing preview manager and preload. It does not add a frame runtime, annotation worker, global IPC redesign, broker redesign, or webview lifecycle layer.

UI Changes

Iframe elements can be selected and annotated as part of the same preview. Frame-local visuals scroll and clip with their content. The main editor hides when its targets leave the visible preview.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Jul 19, 2026
@tarik02
tarik02 force-pushed the feat/preview-iframe-support branch from 97fb407 to 284e958 Compare July 19, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant