Skip to content

perf(protocol): bound stale thread replay - #89

Merged
tarik02 merged 1 commit into
mainfrom
perf/fork-thread-delta-subscription
Jul 29, 2026
Merged

perf(protocol): bound stale thread replay#89
tarik02 merged 1 commit into
mainfrom
perf/fork-thread-delta-subscription

Conversation

@tarik02

@tarik02 tarik02 commented Jul 29, 2026

Copy link
Copy Markdown
Owner

What Changed

  • Added the optional threadDeltaSubscription capability.
  • Added orchestration.subscribeThread.withDelta, which replays gaps up to 1,000 orchestration events and sends a fresh snapshot for larger or invalid gaps.
  • Added a fork-only not-found stream item so clients clear stale cached threads when snapshot fallback finds no active thread.
  • Kept the upstream orchestration.subscribeThread contract and behavior unchanged.
  • Documented the bidirectional fork/upstream compatibility policy in FORK.md.

Why

Reopening a stale large thread can trigger an unbounded event replay. The capability-gated extension bounds that work while upstream clients and backends continue using the unchanged upstream RPC.

Checklist

  • This PR is small and focused
  • I explained what changed and why

Model: GPT-5
Harness: T3 Code

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Jul 29, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a1af79c4a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/server/src/ws.ts
Comment thread apps/server/src/ws.ts Outdated
@tarik02
tarik02 force-pushed the perf/fork-thread-delta-subscription branch from a1af79c to 3ad2fef Compare July 29, 2026 07:39
@tarik02 tarik02 changed the title add fork thread delta subscription perf(protocol): bound stale thread replay Jul 29, 2026
@tarik02
tarik02 merged commit 1eeb2d8 into main Jul 29, 2026
13 of 14 checks passed
@tarik02
tarik02 deleted the perf/fork-thread-delta-subscription branch July 29, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant