fix: Fix Psalm warnings in test files by Copilot · Pull Request #3264 · tarlepp/symfony-flex-backend

Copilot · 2026-05-01T12:57:00Z

Review baseline tooling status and verify local validation prerequisites
Inspect all five targeted files from the cleanup list
Remove stale/redundant transformer inline Psalm annotations if present
Remove repository method suppressions on findBy/findAll/findOneBy if present
Remove @phpstan-ignore return.type in save() if present
Verify and correct @psalm-param docblocks in RestRequestMapper.php
Run available validation for changed files and push updates

…MixedMethodCall, MixedAssignment Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/e68a2937-cc2c-4312-8159-7218cafe5e3a Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

… suppression Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/e68a2937-cc2c-4312-8159-7218cafe5e3a Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…fix) Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/e312d7cb-3e47-4538-b16f-d5d41c011522 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/78d89f47-7de4-4e36-ab43-ddc7a32f49f6 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/4096709e-63c9-4497-b05f-1a0760825f91 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…docblock Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/030430ff-403d-4539-a870-888a917e3a15 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…to fix CI Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/1c7a4768-baf7-4d3e-a91e-bdc7071fc1d3 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…after type annotation improvements Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/0b39dc48-9bb2-48ca-98a6-2c2e95b90373 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…arnings # Conflicts: # tests/Integration/TestCase/EntityTestCase.php Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…ityTestCase Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/8260d138-118b-4909-9c21-b20ed68652de Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…ng PHPStan error Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/eb5deec2-4703-4bd3-99fb-938525feb61a Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…icks up type narrowing Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/088932ac-a907-41b2-a5b3-c6a7aceed48f Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…e call to fix PHPStan error Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/ac4f260c-8984-42be-987a-60d070ff80cc Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…ix Psalm MixedReturnTypeCoercion in getIds() Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/ac9ebd19-0ce6-413b-89b5-7704060ee72e Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

- EnumType::convertToDatabaseValue($value) → mixed $value - EnumType::convertToPHPValue($value) → mixed $value - RestRequestMapper::map($source) → mixed $source - RestRequestMapper::mapToObject($source, $destination) → mixed $source, object $destination Matches existing pattern in UTCDateTimeType which already uses mixed $value. Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/3045cfe7-b529-4f28-acf1-cb2165415bfc Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…atisfy PHP interface compatibility Adding `object` as a type hint narrows the parent MapperInterface::mapToObject's untyped $destination parameter, which PHP rejects with a Fatal error. Use `mixed` instead (which is compatible), and rely on the existing @psalm-param annotation for more specific typing. Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/5b143a84-a27c-422e-82e3-eae867a786f8 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…sourceBaseMethods Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/cdbdf116-4a17-4c57-bfaa-3005a4854959 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…plate annotations on Form types and DataTransformers Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/cdbdf116-4a17-4c57-bfaa-3005a4854959 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…rayObject<array-key, mixed> on StringableArrayObject Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/cdbdf116-4a17-4c57-bfaa-3005a4854959 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…implements

…implements to match actual return type Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/358e6c0a-ee0e-430b-8b21-2ff996b22a11 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

@implements

…pTransformer that conflict with @implements template Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/90c29380-3b91-400f-b54d-b72d733ba8f6 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

@implements

… RoleTransformer that conflict with @implements template Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/7974fed5-f5c1-4cff-9bea-178af2603273 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…asts in RepositoryMethodsTrait and RestResourceBaseMethods Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/8704d10b-523f-4b08-a231-02b33c38c3d8 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…epositoryMethodsTrait and HealthzRepository Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/8828e58e-b70a-49c3-b0c6-95427574f125 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…r (Controller, RequestHandler, SearchTerm, BaseRepository) Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/f18751f2-09b8-4bf3-9076-1baed7900b61 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…scriber/decorator/repository/automapper/resolver layers Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/e3f0befc-1be6-4476-a33d-15ac901d6913 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/6aa666ea-5a3a-4342-b160-8f774c5e3489 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/15ddeedc-1d2e-40ba-80e1-d01b08c0ca0f Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…code and mb_convert_encoding results Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/1aeba7bd-847f-43fc-80d5-7d09e1aca25b Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/f1a6a025-b2a4-45e6-bf49-468407c62a02 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/5e2f3772-1b23-4caf-a574-ee5686d27303 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…erm types throughout Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/74c2eda1-9d85-4b9b-a951-9422d1100efd Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…ing psalm-suppress Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/38205b6f-ce41-4731-a13b-83ce03512d54 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…arrowing Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/8112f28f-a325-44e1-9838-542cc8ea885b Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/03f8f09a-7d5a-4d33-ad57-70feef2736d1 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/72e2ed84-ae60-4dea-ae6b-95f6ac345414 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/e89fb156-6784-463e-acae-d2d64d2c6226 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/79272891-4c2f-4337-a697-9f17db0fece7 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/5a1844bc-25d2-41ac-bcbe-71718a60162f Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

…vior Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/ee1ec6ff-5b23-4932-a61a-ec869e4e9731 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Copilot AI and others added 2 commits May 1, 2026 12:54

fix: use type assertion instead of filter for implode, clean up psalm…

40536c2

… suppression Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/e68a2937-cc2c-4312-8159-7218cafe5e3a Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Copilot AI assigned Copilot and tarlepp May 1, 2026

Copilot created this pull request from a session on behalf of tarlepp May 1, 2026 12:59 View session

Copilot finished work on behalf of tarlepp May 1, 2026 12:59

Copilot AI requested a review from tarlepp May 1, 2026 12:59

Copilot started work on behalf of tarlepp May 1, 2026 13:02 View session

fix: remove blank lines between psalm-suppress and @return tags (ECS …

adb3699

…fix) Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/e312d7cb-3e47-4538-b16f-d5d41c011522 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Copilot finished work on behalf of tarlepp May 1, 2026 13:04

Copilot started work on behalf of tarlepp May 1, 2026 13:09 View session

fix: resolve remaining Psalm errors in test files

acc2cd2

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/78d89f47-7de4-4e36-ab43-ddc7a32f49f6 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Copilot finished work on behalf of tarlepp May 1, 2026 13:18

Copilot started work on behalf of tarlepp May 1, 2026 13:37 View session

fix: wrap long phpstan-return annotations to stay within 120 char limit

2c7ef5e

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/4096709e-63c9-4497-b05f-1a0760825f91 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Copilot finished work on behalf of tarlepp May 1, 2026 13:39

Copilot started work on behalf of tarlepp May 1, 2026 14:19 View session

fix: restore missing method declaration in CountMethodTest corrupted …

e0654a1

…docblock Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/030430ff-403d-4539-a870-888a917e3a15 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Copilot finished work on behalf of tarlepp May 1, 2026 14:22

Copilot started work on behalf of tarlepp May 1, 2026 15:59 View session

fix: add PossiblyInvalidArgument suppression in psalm.xml for tests/ …

baccff5

…to fix CI Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/1c7a4768-baf7-4d3e-a91e-bdc7071fc1d3 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Copilot finished work on behalf of tarlepp May 1, 2026 16:10

Copilot started work on behalf of tarlepp May 3, 2026 10:46 View session

Copilot finished work on behalf of tarlepp May 3, 2026 10:52

Copilot started work on behalf of tarlepp May 3, 2026 10:54 View session

Merge remote-tracking branch 'origin/master' into copilot/fix-psalm-w…

82c82ed

…arnings # Conflicts: # tests/Integration/TestCase/EntityTestCase.php Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Copilot finished work on behalf of tarlepp May 3, 2026 10:57

Copilot started work on behalf of tarlepp May 3, 2026 11:11 View session

fix: adjust phpstan-ignore-line annotations after master merge in Ent…

f01bf36

…ityTestCase Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/8260d138-118b-4909-9c21-b20ed68652de Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Copilot AI and others added 30 commits May 5, 2026 19:27

fix: Add @var array<int, TEntity> annotation in find() to fix remaini…

1a86da3

…ng PHPStan error Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/eb5deec2-4703-4bd3-99fb-938525feb61a Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

fix: Merge @var and @psalm-suppress into single docblock so PHPStan p…

1df9e60

…icks up type narrowing Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/088932ac-a907-41b2-a5b3-c6a7aceed48f Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

fix: Re-assert array<int, TEntity> type after afterFind() by-referenc…

9b0463f

…e call to fix PHPStan error Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/ac4f260c-8984-42be-987a-60d070ff80cc Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

fix(psalm): remove MixedArgumentTypeCoercion suppressions from RestRe…

7f0be6f

…sourceBaseMethods Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/cdbdf116-4a17-4c57-bfaa-3005a4854959 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

fix(psalm): fix 2 Psalm errors causing CI failure

d7c6d14

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/6aa666ea-5a3a-4342-b160-8f774c5e3489 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

fix(phpcs): fix closing brace style in anonymous class

606ae84

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/15ddeedc-1d2e-40ba-80e1-d01b08c0ca0f Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Fix 15 Psalm warnings: MixedAssignment and MixedArgumentTypeCoercion

a441637

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/f1a6a025-b2a4-45e6-bf49-468407c62a02 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Fix Psalm warnings properly: fix root types instead of using @var hacks

a410f41

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/5e2f3772-1b23-4caf-a574-ee5686d27303 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Fix 4 new Psalm errors: remove redundant is_array check, fix search t…

d32ca2b

…erm types throughout Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/74c2eda1-9d85-4b9b-a951-9422d1100efd Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Fix test failure: restore scalar order param support in getOrderBy us…

328016c

…ing psalm-suppress Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/38205b6f-ce41-4731-a13b-83ce03512d54 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Fix 7 Psalm MixedArgumentTypeCoercion warnings via inline psalm-var n…

a67d0a0

…arrowing Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/8112f28f-a325-44e1-9838-542cc8ea885b Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Fix remaining Psalm warnings in RestResourceBaseMethods

d2ab431

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/03f8f09a-7d5a-4d33-ad57-70feef2736d1 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Refactor: extract normalizeOrderBy and normalizeCriteria helper methods

40f0d98

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/72e2ed84-ae60-4dea-ae6b-95f6ac345414 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Fix: wrap long findByAdvanced call to stay within 120-char line limit

a0386ae

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/e89fb156-6784-463e-acae-d2d64d2c6226 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Fix Psalm mixed assignment warnings in normalization helpers

b0655e0

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/79272891-4c2f-4337-a697-9f17db0fece7 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Suppress final Psalm MixedAssignment warning in normalizeCriteria

9beffca

Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/5a1844bc-25d2-41ac-bcbe-71718a60162f Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Align RestRequestMapper Psalm source docblocks with Request-only beha…

a004d27

…vior Agent-Logs-Url: https://github.com/tarlepp/symfony-flex-backend/sessions/ee1ec6ff-5b23-4932-a61a-ec869e4e9731 Co-authored-by: tarlepp <595561+tarlepp@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Fix Psalm warnings in test files#3264

fix: Fix Psalm warnings in test files#3264
Copilot wants to merge 122 commits intomasterfrom
copilot/fix-psalm-warnings

Copilot AI commented May 1, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 1, 2026 •

edited

Loading