Remove mention of automatic use of env vars from RFC#128#134
Merged
djmitche merged 1 commit intotaskcluster:masterfrom Nov 16, 2018
Merged
Remove mention of automatic use of env vars from RFC#128#134djmitche merged 1 commit intotaskcluster:masterfrom
djmitche merged 1 commit intotaskcluster:masterfrom
Conversation
This introduced a breaking change, and was not widely circulated among users during the RFC discussion process. Since it is largely orthogonal to this RFC, we will move it to another, fresh RFC for discussion.
petemoore
approved these changes
Nov 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduced a breaking change, and was not widely circulated among
users during the RFC discussion process. Since it is largely orthogonal
to this RFC, let's move it to another, fresh RFC for discussion.
In particular, as I consider beginning work on modifying clients, I'm not sure if I should do what we discussed (make them not take any environment variables) or what was written in the RFC (take TASKCLUSTER_CLIENT_ID, etc., but not TASKCLUSTER_ROOT_URL). But I want to move on with the rest of #128, so I think it's best to just defer this particular question to a new RFC (which I will have up shortly).