Skip to content

NIP-99 ClassifiedListingEvent API, Event, Tag and Serializer classes#156

Merged
tcheeric merged 38 commits intotcheeric:developfrom
avlo:develop
Apr 29, 2024
Merged

NIP-99 ClassifiedListingEvent API, Event, Tag and Serializer classes#156
tcheeric merged 38 commits intotcheeric:developfrom
avlo:develop

Conversation

@avlo
Copy link
Copy Markdown
Collaborator

@avlo avlo commented Apr 29, 2024

New classes added as per NIP-99 specification

@@ -1,53 +1,56 @@
package nostr.event;
Copy link
Copy Markdown
Collaborator Author

@avlo avlo Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines 33-35 are sole additions. however, entire file contains hidden DOS CR/LF (^M) characters at EOL:

$ dos2unix -id nostr-java-event/src/main/java/nostr/event/Kind.java
53  nostr-java-event/src/main/java/nostr/event/Kind.java

worth considering having git manage line endings automatically as per line-endings configuration described on GitHub

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines 33-35 are sole additions. however, entire file contains hidden DOS CR/LF (^M) characters at EOL:

$ dos2unix -id nostr-java-event/src/main/java/nostr/event/Kind.java
53  nostr-java-event/src/main/java/nostr/event/Kind.java

worth considering having git manage line endings automatically as per line-endings configuration described on GitHub

Noted, thank you

@tcheeric tcheeric merged commit 37e8f35 into tcheeric:develop Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants