Merged
Conversation
- new classes per this branch - updating/evolving existing implementation - new Kind added for zaps - minor refactor in NIP01 successful compilation snapshot
updated abstract class NIP57Event constructors req'd params amount type from Integer to Long (larger range for millisats) updated serializers
removed use of Relay as RelayInfo doc, which is NIP11, not NIP57
…57 parameters added variad constructor to RelaysTag
…ters NIP57Event abstract class removed since no useful common attributes between ZapRequestEvent and ZapReceiptEvent
PriceTagSerializer structural adjustments PriceTagDeserializer unit tests
ClassifiedListing renamed to ClassifiedListingTag ClassifiedListingTagSerializer updates ClassifiedListingEvent unit tests
ZapReceipt moved to its own class ClassifiedListingTag moved back to ClassifiedListing (as it's technically not a tag)
ZapRequest moved into impl ClassifiedListing moved into impl ClassifiedListingTagSerializer renamed to ClassifiedListingSerializer reverted ClassifiedListingSerializer to original implementation reverted PriceTag to original implementation updated unit tests
ClassifiedListingEvent ctor update
…ady existing BaseTag)
Owner
|
Nick, thanks for this. I will work on this today. |
removed serializers, done via jackson json annotations instead ZapRequestEvent/ReceiptEvent constructor updates
Collaborator
Author
yw, eric. apologies for the multiple commits since initial PR. there were serializer refactorings (in this case, significant code reduction via jackson w/o need for explicit serializer implementations)... as well as having to back out filtering logic i'd added to classified listings after discovering you've already accommodated for the same directly in GenericEvent.addTag() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuing NIP57 implementation:
- new classes per this branch
- updating/evolving existing implementation
- new Kind added for zaps
- minor refactor in NIP01
culled unused abstract class NIP57Event constructors
updated abstract class NIP57Event constructors req'd params
amount type from Integer to Long (larger range for millisats)
updated serializers
implemented proper RelaysTag/RelaysTags methods
removed use of Relay as RelayInfo doc, which is NIP11, not NIP57
removed NIP57Event @NoArgsConstructor as it curcumvents necessary NIP57 parameters
added variad constructor to RelaysTag
NIP57 & NIP57Impl updated to accomodate required NIP57 receipt parameters
NIP57Event abstract class removed since no useful common attributes between ZapRequestEvent and ZapReceiptEvent
NIP57 createZapRequestEvent unit tests
NIP57 createZapReceiptEvent unit tests
NIP57Impl ZapRequestEventFactory unit tests