Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the project version from 0.7.1-SNAPSHOT to 0.7.2-SNAPSHOT across all Maven modules and disables integration tests that require network access to external relays.
- Version update across all Maven POMs and Gradle build files
- Disabled integration tests requiring network connectivity
- Updated README example with new version reference
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Updated parent version and property version to 0.7.2-SNAPSHOT |
| Various module pom.xml files | Updated parent version reference to 0.7.2-SNAPSHOT |
| Integration test files | Added @disabled annotations to prevent network-dependent tests from running |
| gradle.properties | Updated version property to 0.7.2-SNAPSHOT |
| buildSrc/build.gradle | Updated version to 0.7.2-SNAPSHOT |
| README.md | Updated example version reference to v0.007.2-alpha |
| ```xml | ||
| <properties> | ||
| <nostr-java.version>v0.007.1-alpha</nostr-java.version> | ||
| <nostr-java.version>v0.007.2-alpha</nostr-java.version> |
There was a problem hiding this comment.
The version format in README.md (v0.007.2-alpha) is inconsistent with the actual project version format (0.7.2-SNAPSHOT) used throughout the POMs and Gradle files. This could confuse users about which version format to use.
Suggested change
| <nostr-java.version>v0.007.2-alpha</nostr-java.version> | |
| <nostr-java.version>0.7.2-SNAPSHOT</nostr-java.version> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
mvn -q verifyhttps://chatgpt.com/codex/tasks/task_b_68880de8efac8331ad5ea066d75f58a8