Convert the marker string to uppercase (issue #49)#50
Merged
tcheeric merged 2 commits intotcheeric:feature/feature_bug_fixesfrom Jun 27, 2023
Memory-of-Snow:Convert_the_marker_string_to_uppercase
Merged
Convert the marker string to uppercase (issue #49)#50tcheeric merged 2 commits intotcheeric:feature/feature_bug_fixesfrom Memory-of-Snow:Convert_the_marker_string_to_uppercase
tcheeric merged 2 commits intotcheeric:feature/feature_bug_fixesfrom
Memory-of-Snow:Convert_the_marker_string_to_uppercase
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The summary of the changes
Change to setting the marker after converting the marker string to uppercase.
Why are these changes being made
Since the JSON marker string is in lowercase, it doesn't match the Enum value and causes an exception to be thrown.
The details of the changes.
I have made changes to convert the marker string to uppercase before setting the marker object when the tag is 'e' in TagDeserializer.java.
And make DecodeTest.