fix: hide signup buttons when disallowSignUp is configured

[boris-w]

No description provided.

[Copilot]

Pull Request Overview

This PR implements a fix to hide signup buttons when signup is disabled via configuration.

• Updates the login route with server-side hydration using a public setting query.
• Introduces a new hook (useDisallowSignUp) to determine whether signup should be hidden.
• Conditionally renders signup links in both LoginPage and SignForm components based on the disallowSignUp flag.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
apps/nextjs-app/src/pages/auth/login.tsx	Adds hydration support and fetches public settings server-side to provide the disallowSignUp flag.
apps/nextjs-app/src/features/auth/useDisallowSignUp.ts	Implements a hook to retrieve the public setting that controls signup visibility.
apps/nextjs-app/src/features/auth/pages/LoginPage.tsx	Uses the disallowSignUp flag to conditionally render the signup button.
apps/nextjs-app/src/features/auth/components/SignForm.tsx	Uses the disallowSignUp flag to hide the signup link when in signin mode.

[Copilot]

Consider returning a default boolean value (e.g., false) when 'setting' is undefined to ensure a consistent evaluation of the disallowSignUp flag.

Suggested change

	return disallowSignUp;
	return disallowSignUp ?? false;

[Copilot]

[nitpick] The conditional rendering for the signup link appears in both LoginPage and SignForm. Consider centralizing this logic to avoid duplication and improve maintainability.

[Copilot]

[nitpick] Consider adding error handling around the API call to fetch public settings to gracefully manage potential service failures on the server side.

Suggested change

	await Promise.all([
	queryClient.fetchQuery({
	queryKey: ReactQueryKeys.getPublicSetting(),
	queryFn: () => ssrApi.getPublicSetting(),
	}),
	]);
	try {
	await Promise.all([
	queryClient.fetchQuery({
	queryKey: ReactQueryKeys.getPublicSetting(),
	queryFn: () => ssrApi.getPublicSetting(),
	}),
	]);
	} catch (error) {
	console.error("Failed to fetch public settings:", error);
	// Optionally, handle fallback logic here if needed
	}

[github-actions]

🧹 Preview Environment Cleanup

• PR fix: hide signup buttons when disallowSignUp is configured #1498 has been Merged
• Preview environment has been deleted
• Cleanup time: 2025-05-06T03:20:59.360Z