feat: multi-line field names & batch collapse by group#1504
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This feature PR introduces support for multi-line field names and batch collapse of group headers. Key changes include updates to GridView components and toolbar handlers to support a new fieldNameDisplayLines option, the addition of a new constant for field name height definitions, and backend updates to return additional group header references.
Reviewed Changes
Copilot reviewed 42 out of 51 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/nextjs-app/src/features/app/blocks/view/tool-bar/components/GridViewOperators.tsx | Updated import and callback handlers to support fieldNameDisplayLines. |
| apps/nextjs-app/src/features/app/blocks/view/hooks/useToolbarChange.ts | Added onFieldNameDisplayLinesChange to update view options. |
| apps/nextjs-app/src/features/app/blocks/view/grid/const.ts | Added GIRD_FIELD_NAME_HEIGHT_DEFINITIONS constant. |
| apps/nextjs-app/src/features/app/blocks/view/grid/components/GroupHeaderMenu.tsx | Introduced new GroupHeaderMenu component for group collapse/expand. |
| apps/nextjs-app/src/features/app/blocks/view/grid/GridViewBaseInner.tsx | Integrated new height definitions and added onGroupHeaderContextMenu. |
| apps/nextjs-app/src/features/app/blocks/view/grid/DomBox.tsx | Included GroupHeaderMenu in the DOM box component. |
| apps/nextjs-app/src/features/app/blocks/share/view/component/grid/toolbar/Toolbar.tsx | Enhanced toolbar to handle fieldNameDisplayLines. |
| apps/nextjs-app/src/features/app/blocks/share/view/component/grid/GridViewBase.tsx | Updated grid view to use new options and added onColumnFreeze and onGroupHeaderContextMenu. |
| apps/nestjs-backend/test/aggregation.e2e-spec.ts | Added tests for group header references behavior. |
| apps/nestjs-backend/src/features/record/record.service.ts | Modified RecordService to include allGroupHeaderRefs in responses. |
Files not reviewed (9)
- packages/common-i18n/src/locales/de/sdk.json: Language not supported
- packages/common-i18n/src/locales/de/table.json: Language not supported
- packages/common-i18n/src/locales/en/sdk.json: Language not supported
- packages/common-i18n/src/locales/en/table.json: Language not supported
- packages/common-i18n/src/locales/es/sdk.json: Language not supported
- packages/common-i18n/src/locales/es/table.json: Language not supported
- packages/common-i18n/src/locales/fr/sdk.json: Language not supported
- packages/common-i18n/src/locales/fr/table.json: Language not supported
- packages/common-i18n/src/locales/it/sdk.json: Language not supported
Comments suppressed due to low confidence (1)
apps/nextjs-app/src/features/app/blocks/view/grid/const.ts:11
- [nitpick] The constant name 'GIRD_FIELD_NAME_HEIGHT_DEFINITIONS' may be a typo. For clarity and consistency, consider renaming it to 'GRID_FIELD_NAME_HEIGHT_DEFINITIONS' if appropriate.
export const GIRD_FIELD_NAME_HEIGHT_DEFINITIONS = [0, 32, 56, 80];
Collaborator
Pull Request Test Coverage Report for Build 14828572373Details
💛 - Coveralls |
Contributor
|
Deployment Status: ✅ Success |
Contributor
|
Deployment Status: ✅ Success |
Contributor
🧹 Preview Environment Cleanup
|
tea-artist
pushed a commit
that referenced
this pull request
Mar 24, 2026
tea-artist
added a commit
that referenced
this pull request
Mar 24, 2026
Synced from teableio/teable-ee@5105c9b Co-authored-by: nichenqin <nichenqin@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.