fix: correct paste misalignment when using shuffled projection (T1329)#2325
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a paste misalignment bug that occurred when using shuffled field projections (issue T1329). When projection was specified, the fields were being incorrectly reordered by subsequent view processing logic, causing pasted data to be written to the wrong columns.
- Fixed the early return logic in
getFieldsByQueryto prevent projection results from being processed by viewId logic - Added comprehensive test coverage for paste operations with various projection scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/nestjs-backend/src/features/field/field.service.ts | Changed projection handling to return immediately instead of continuing to viewId processing, preventing field reordering that caused paste misalignment |
| apps/nestjs-backend/test/selection.e2e-spec.ts | Added comprehensive E2E test suite covering paste operations with shuffled, reversed, and offset projections to verify the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
🧹 Preview Environment Cleanup
|
Collaborator
Pull Request Test Coverage Report for Build 20454531600Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues: T1329