Merged
Conversation
…s in the subsystems
…cs/FRC-2023 into feat/actual_claw
jkleiber
suggested changes
Jan 28, 2023
Contributor
jkleiber
left a comment
jkleiber
left a comment
There was a problem hiding this comment.
The bare bones are here, but we need to only include relevant code. Once the swerve branch gets merged, hopefully a lot of these file changes go away - we need to make sure this branch doesn't overwrite hard work done on other branches.
Collaborator
|
@jkleiber this builds but fails the unit tests because of the WPILib logging issue |
jkleiber
approved these changes
Feb 21, 2023
Contributor
jkleiber
left a comment
jkleiber
left a comment
There was a problem hiding this comment.
Looks good to me @X-EX3-X @danielbrownmsm feel free to merge
danielbrownmsm
approved these changes
Feb 23, 2023
Collaborator
danielbrownmsm
left a comment
danielbrownmsm
left a comment
There was a problem hiding this comment.
yeah we can merge. will need to add a lot of stuff, but this is a good skeleton
| bool Claw::SetPosition(){ | ||
| // SetPosition (30); //cone | ||
| // SetPosition (0); //close | ||
| // SetPosition (50);//cube |
Collaborator
There was a problem hiding this comment.
I mean, really this PR has no functionality, but at least getting the framework is something
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for justin to check