Open
Conversation
* code for new intake with wrist still need to write commands for it though * actually create hardware objects for the new intake * update values from hardware in the software interface
* field oreinted scoring written, builds, untested * field-oriented scoring tested, works * left and right bumpers for pickup positions so we can pickup on both sides of the robot
* code for new intake with wrist still need to write commands for it though * actually create hardware objects for the new intake * update values from hardware in the software interface * wrote commands to move the wrist to a certain position, either just straight to a position or incrementing it * bind some of the wrist commands we need * wrist tilt encoder on shuffleboard * clean up the intake commands and add some more OKC_CALL stuff * add an offset to the tilt encoder * fix intake parameters * more okc checks
…otics/FRC-2023 into scoring-integration
…spot and fix the setpoints
…otics/FRC-2023 into scoring-integration
… slower, make either the arm or intake move first depending on the context to avoid breaking the robot, among other things
…ith a game piece that would break something
…he tilted station, not the one with the door) and of course tune some more septoints
…round anymore though, not without ADDING ANOTHER STUPID BUTTON which would probably be the d-pad but that didn't work out so well at shawnee so anyways
…der reading in the arm-viz script
… start of auto if we start down
I love life so much I want to go and outlive all the other teams and laugh on their graves
… stuff because new intake YYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYAAAAAAAAAAAAAAAAAAYYYYY
…otics/FRC-2023 into feat/drive-straight
Collaborator
danielbrownmsm
left a comment
danielbrownmsm
left a comment
There was a problem hiding this comment.
@noahzemlin double check this
@AbbeySieg fix the things I mentioned
| id "cpp" | ||
| id "google-test-test-suite" | ||
| id "edu.wpi.first.GradleRIO" version "2023.4.2" | ||
| id "edu.wpi.first.GradleRIO" version "2023.4.3" |
Collaborator
There was a problem hiding this comment.
we should not add all these to master
src/main/cpp/subsystems/Intake.cpp
Outdated
| @@ -47,9 +40,6 @@ void Intake::Periodic() { | |||
| case Manual: | |||
| VOKC_CALL(this->ManualControl()); | |||
Collaborator
There was a problem hiding this comment.
we should probably just remove any kind of different manual/auto control
| # units are in meters | ||
| x_disp = 0.216 | ||
| y_disp = 0.416 | ||
| y_disp = 0.216 |
Collaborator
There was a problem hiding this comment.
weird change but if it got better in drive practice
| double intake_power_; | ||
|
|
||
| ControlMode mode_ = Auto; | ||
| ControlMode mode_ = Manual; |
Collaborator
There was a problem hiding this comment.
see note above about control modes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.