feat(HPAs): resolves #135 recreate HPAs from db on load#136
Merged
Cryptophobia merged 1 commit intoteamhephy:masterfrom Oct 16, 2020
Merged
feat(HPAs): resolves #135 recreate HPAs from db on load#136Cryptophobia merged 1 commit intoteamhephy:masterfrom
Cryptophobia merged 1 commit intoteamhephy:masterfrom
Conversation
Signed-off-by: Cryptophobia <aouzounov@gmail.com>
Member
Author
|
Local unit test and local minikube testing passes for me. Had to modify the function. There are multiple appsettings per app. We only care about the latest one. We use app.structure for the proc_types only if appsettings.autoscale is set. If autoscale is unset on deis, then the hpa should not be created and should return an error. This is the intended behaviour as we assume deis/hephy controller is master of its own namespaces (apps). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cryptophobia aouzounov@gmail.com
resolves #135
@dmcnaught @kingdonb
Local unit test and local minikube testing passes for me. Had to modify the function.
There are multiple appsettings per app. We only care about the latest one. We use app.structure for the proc_types only if appsettings.autoscale is set. If autoscale is unset on deis, then the hpa should not be created and should return an error.
This is the intended behaviour as we assume deis/hephy controller is master of its own namespaces (apps).