Open
Conversation
-Prevents @*.local email addresses from ever syncing to TeamViewer, even if mail or legacy attributes are misconfigured -Fixes incorrect reliance on the mail attribute in non-Exchange on-prem AD environments where it is empty or wrong -Ensures UPN (userPrincipalName) is treated as authoritative when it contains a valid external domain -Stops TeamViewer from auto-creating accounts with non-routable internal domains -Preserves existing group membership search logic (recursive/non-recursive behavior unchanged). -Properly parses SMTP entries in proxyAddresses without assuming Exchange schema usage -Eliminates silent fallbacks that previously defaulted to user@domain.local -Adds a hard guard rail so invalid internal domains cannot reappear via future schema changes or bad data. -Supports mixed environments (some users with UPN only, some with legacy attributes) -Adds an operator-controlled fallback to construct samAccountName@externaldomain when no valid external address exists. -Ensures the fallback decision is prompted once per run, avoiding repetitive prompts -Prevents duplicate or conflicting emails by deduplicating candidate values -Keeps TeamViewer account matching stable by supplying consistent, externally valid identifiers -Avoids any dependency on Exchange, Entra ID Connect, or O365 schema extensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Prevents @*.local email addresses from ever syncing to TeamViewer, even if mail or legacy attributes are misconfigured
-Fixes incorrect reliance on the mail attribute in non-Exchange on-prem AD environments where it is empty or wrong
-Ensures UPN (userPrincipalName) is treated as authoritative when it contains a valid external domain
-Stops TeamViewer from auto-creating accounts with non-routable internal domains
-Preserves existing group membership search logic (recursive/non-recursive behavior unchanged). -Properly parses SMTP entries in proxyAddresses without assuming Exchange schema usage
-Eliminates silent fallbacks that previously defaulted to user@domain.local
-Adds a hard guard rail so invalid internal domains cannot reappear via future schema changes or bad data.
-Supports mixed environments (some users with UPN only, some with legacy attributes)
-Adds an operator-controlled fallback to construct samAccountName@externaldomain when no valid external address exists.
-Ensures the fallback decision is prompted once per run, avoiding repetitive prompts
-Prevents duplicate or conflicting emails by deduplicating candidate values
-Keeps TeamViewer account matching stable by supplying consistent, externally valid identifiers
-Avoids any dependency on Exchange, Entra ID Connect, or O365 schema extensions