problem with showHeadersOnEveryPage

[Sgkhour]

Hi , i am using TPPDF 2.2.0 and integrating in a personal iOS app i am writing . a great library , thank you but i am trying to understand showHeadersOnEveryPage
when showHeadersOnEveryPage is true, the header row overwrites the top row on the next page and ends up hiding it.
i don't see any properties to add space after the header row. being new, i might have overlooked something

here are two screenshots.. without a header and with. the 20:12 entry is overwritten by the header row

thank you
Sami

[philprime]

Hi Sami,

looks like this is the same issue as #205, actually a bug from my side.

Is it possible you can create me a small code sample I can run locally to reproduce your issue?
It would help tremendously.

[Sgkhour]

Philip, thank you for the followup, here is my generateDocument function , trimmed to the bare minimum but with the style parameters i used. only thing you need is a reference to a uiimage inside the row loop. the third column is the row number. and you can see it jumps from 24 to 26 (25 being overwritten by the header. i suspect it is an offset issue since regardless of showheader being true or false, row 25 is always at the same spot on the page. let me know if you need anything else , happy to help. Sami

 func generateDocument() -> [PDFDocument] {
        var timeString: String = ""
        var imgName = UIImage()
        var volume: String = ""
        var description: String = ""
        
        let numberOfRowns = 35
        let document = PDFDocument(format: .usLetter)

        let eventsTable = PDFTable(rows: numberOfRowns + 1, columns: 4)
        eventsTable.widths = [0.1, 0.05, 0.1, 0.75]
        eventsTable.padding = 1.0
        eventsTable.margin = 2.0

        eventsTable.showHeadersOnEveryPage = true

        let eventsTableTopRowStyle = PDFTableCellStyle.init(colors: (fill: Color.systemBlue,
                                                          text: Color.white),
                                                 borders: PDFTableCellBorders(left: PDFLineStyle(type: .none),
                                                                              top: PDFLineStyle(type: .none),
                                                                              right: PDFLineStyle(type: .none),
                                                                              bottom: PDFLineStyle(type: .none)),
                                                 font: Font.boldSystemFont(ofSize: 10.0))

        let eventsTableContentStyle = PDFTableCellStyle.init(colors: (fill: Color.white,
                                                        text: Color.black),
                                               borders: PDFTableCellBorders(left: PDFLineStyle(type: .none),
                                                                            top: PDFLineStyle(type: .none),
                                                                            right: PDFLineStyle(type: .none),
                                                                            bottom: PDFLineStyle(type: .none)),
                                               font: Font.systemFont(ofSize: 10))

        eventsTable.style = PDFTableStyle(rowHeaderCount: 0,
                                          columnHeaderCount: 1,
                                          footerCount: 0,
                                          columnHeaderStyle: eventsTableTopRowStyle,
                                          contentStyle: eventsTableContentStyle,
                                          alternatingContentStyle: eventsTableContentStyle)

        let myrow = eventsTable[row: 0]
        myrow.content = ["Time", nil, "Vol.", "Description"]
        myrow.alignment = [.center, .center, .center, .center]

        let dateFormat = DateFormatter()
        dateFormat.dateFormat = "HH:mm"

        for ndx in 0..<numberOfRowns {
            timeString = dateFormat.string(from: Date())
            description = "this is a description"
            volume = String(ndx)
            imgName = UIImage(named: "stats")!
              
            let myrow = eventsTable[row: ndx+1]
            myrow.content = [timeString, imgName, volume, description]
            myrow.alignment = [.right, .center, . right, .left]
        }
        
        let titleDateFormat = DateFormatter()
        titleDateFormat.dateStyle = .full
        titleDateFormat.timeStyle = .none

        let docTitleStyle = document.add(style: PDFTextStyle(name: "Title",
                                                          font: UIFont.boldSystemFont(ofSize: 24.0),
                                                          color: UIColor(red: 0.171875, green: 0.2421875, blue: 0.3125, alpha: 1.0)))
 
        document.add(textObject: PDFSimpleText(text: titleDateFormat.string(from: Date()), style: docTitleStyle))
        document.add(space: 32.0)

        document.add(table: eventsTable)
        document.add(space: 16.0)

         return [document]
    }

[philprime]

Thanks a lot! I will try to reproduce it in the TPPDF experiment sample, so I can use it for testing and investigating.

[philprime]

Alright, with 2.3.2 it the "shouldSplitCellsOnPageBreak" option should fix at least the half cells.

I am not quite certain that showHeadersOnEveryPage is not working correctly, but that does take more time to analyze (see #250)

[moored]

I am seeing the same behavior with the header overwriting the top cell/cells. Have shouldSplitCellsOnPageBreak = false and showHeadersOnEveryPage = true.

[moored]

Note sure if this is related but the header.spacer is not being enforced on additional pages.

[Sgkhour]

for what its worth, i worked on this issue trying to run it down, created a fork and have coded a workaround. not sure if it is a clean solution but feel free to have a look at it in PDFCalculations.swift and also in PDFTableObject.swift where i added some code to account for handling subsequent pages. i am new to this so if you think it is a solution to the header spacing issue, i could put a pull request...

[moored]

@Sgkhour This does appear to fix the issue, however I don't believe you need line 347, nextPageCells = shiftCellsBy(cells: nextPageCells, shiftValue: table.padding) as it causes additional spacing between the header and the first row on pages > 2. Also, some refactoring is needed since your changes are based on the master branch and not the current develop branch. Very nice work!

[philprime]

I am happy to review a PR. I justed pushed a fix for outdated gem dependencies, so master and develop are on the same commit now. Please rebase any changes before creating a PR

Edit:
Also code-review is easier in a PR as we can comment on specific lines (similar to what @moored just did)

[Sgkhour]

sorry, taking me longer than i hoped to the rebase... new to this and have never done it before so in major learn more today