Skip to content

Fix footer height calculation #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philprime merged 2 commits into from
Dec 5, 2020
Merged

Fix footer height calculation #252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6482074
Fix footer height calculation
lepeanco Dec 1, 2020
97d7017
Apply PR suggestions
lepeanco Dec 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions Source/Internal/Utils/PDFCalculations.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,13 +157,42 @@ internal enum PDFCalculations {
+ layout.heights.maxHeaderHeight()
}

/// Calculates the maximum offset from the top edge when the main content should break to the next page
///
/// This method calculates the limit by the following formula:
///
/// page height
/// - bottom margin
/// - footer height
/// - footer spacing (if footer exists)
/// - padding
/// -----------------------------------
/// offset from top edge
///
/// --- ┏━━━━━━━━━━┓
/// ↑ ┃┌────────┐┃
/// ↓ ┃│ Group │┃
/// --> ┃└────────┘┃
/// ┠┄┄┄┄┄┄┄┄┄┄┨
/// ┃ spacing ┃
/// ┠┄┄┄┄┄┄┄┄┄┄┨
/// ┃ footer ┃
/// ┠┄┄┄┄┄┄┄┄┄┄┨
/// ┃ margin ┃
/// ┗━━━━━━━━━━┛
///
/// - Parameter generator: Generator currently in use holding information about the document
/// - Returns: Offset from top edge in points
internal static func calculateBottomMaximum(for generator: PDFGenerator) -> CGFloat {
let layout = generator.layout
let pageLayout = generator.document.layout
let footerHeight = layout.heights.maxFooterHeight()

return pageLayout.height
- layout.margin.top
- layout.heights.maxHeaderHeight()
- generator.currentPadding.bottom
- (footerHeight > 0 ? pageLayout.space.footer : 0)
- footerHeight
- layout.margin.bottom
}
Comment thread
philprime marked this conversation as resolved.

/**
Expand Down