Add the functionality of TPPDF about image#3
Merged
Conversation
This reverts commit fa05507.
techprimate
reviewed
Dec 1, 2016
| UIGraphicsEndImageContext() | ||
|
|
||
| // compression | ||
| if let image = compressedImage, let jpegData = UIImageJPEGRepresentation(image, imageQuality) { |
Collaborator
There was a problem hiding this comment.
Maybe we should use a guard statement and some kind of error handling in case something goes wrong.
One way would be creating an error enum TPPDFError
techprimate
reviewed
Dec 1, 2016
Collaborator
techprimate
left a comment
techprimate
left a comment
There was a problem hiding this comment.
The headerSpace is below the actual header. Therefore the line should draw directly below the header text and not directly above the content.
Therefore this change is not correct.
…xtFrameAndDrawnSizeInOnePage
…pace is not enough for the table
… height of image size is smaller than the expected height
…DrawnSizeInOnePage to prevent infinite loop to calculate the height of text
Collaborator
|
Merged this pull request, now cleaning up code and optimization before release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The summary of this pull request