Added generator delegate (#231)#319
Merged
Merged
Conversation
SwiftLint found issues
Generated by 🚫 Danger Swift against 9786cbf |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
+ Coverage 0.00% 78.86% +78.86%
==========================================
Files 210 212 +2
Lines 12379 12608 +229
==========================================
+ Hits 0 9943 +9943
+ Misses 12379 2665 -9714
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Contributor
|
This is interesting, but what's the use case for it? Why would you need to know when images are being drawn? Does it make for a more accurate process indicator? Mine usually goes straight to 33%, then to 66%, then to 100%. Would be nice to see more increments. |
Member
Author
c353bda to
61e2170
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #231