GetCssBorderStyle Has Problem When !important Is Specified#467
Merged
nicolaasuni merged 3 commits intotecnickcom:mainfrom Aug 12, 2022
oleibman:borderimportant2
Merged
GetCssBorderStyle Has Problem When !important Is Specified#467nicolaasuni merged 3 commits intotecnickcom:mainfrom oleibman:borderimportant2
nicolaasuni merged 3 commits intotecnickcom:mainfrom
oleibman:borderimportant2
Conversation
This is, in particular, a problem for PhpSpreadsheet. See PHPOffice/PhpSpreadsheet#1164. TCPDF thinks that there can be 0, 1, 2, or 3 components to shorthand border style, but there can be more, e.g. !important. Logic is rearranged to allow for more than 3. A new example file is added to demonstrate that the fix works correctly.
Better code coverage.
nicolaasuni
approved these changes
Aug 12, 2022
oleibman
added a commit
to oleibman/PhpSpreadsheet
that referenced
this pull request
Aug 14, 2022
Implementation of tecnickcom/TCPDF#467, which is available in just-released Tcpdf 6.5, will improve look of Tcpdf rendering for PhpSpreadsheet. Fix PHPOffice#1164. One test had been suppressed for Tcpdf, ostensibly because it was not compatible with Php8. As it turns out, the PhpSpreadsheet code which invokes Tcpdf was (harmlessly) incorrect, so the Php8 issue was actually with PhpSpreadsheet, not Tcpdf. That code is corrected, and the test is no longer suppressed.
7 tasks
oleibman
added a commit
to PHPOffice/PhpSpreadsheet
that referenced
this pull request
Aug 14, 2022
* Upgrade Dev TCPDF to 6.5 Implementation of tecnickcom/TCPDF#467, which is available in just-released Tcpdf 6.5, will improve look of Tcpdf rendering for PhpSpreadsheet. Fix #1164. One test had been suppressed for Tcpdf, ostensibly because it was not compatible with Php8. As it turns out, the PhpSpreadsheet code which invokes Tcpdf was (harmlessly) incorrect, so the Php8 issue was actually with PhpSpreadsheet, not Tcpdf. That code is corrected, and the test is no longer suppressed. * Update Change Log Pick up some earlier changes as well as this one, and deprecations which had been omitted from the 1.24 change log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is, in particular, a problem for PhpSpreadsheet. See PHPOffice/PhpSpreadsheet#1164. TCPDF thinks that there can be 0, 1, 2, or 3 components to shorthand border style, but there can be more, e.g. !important. Logic is rearranged to allow for more than 3. A new example file is added to demonstrate that the fix works correctly.