update the openshift images sha to manifest digest sha#3635
Merged
Conversation
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/M
The get_image_sha() function was using .manifests[0].digest which returns the first platform entry (amd64) instead of the manifest list digest. This causes the operator CSV to pin task images (buildah, s2i, skopeo, ubi-minimal) to amd64-only digests, breaking ARM64 and multi-arch clusters with exec format error. Fix by computing sha256 of the raw manifest list content, which produces the manifest list digest that container runtimes use to resolve the correct platform at pull time. Signed-off-by: ab-ghosh <abghosh@redhat.com>
Signed-off-by: Shiv Verma <shverma@redhat.com>
Contributor
Author
|
/lgtm |
Contributor
|
@pratap0007: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkhelil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Member
|
/lgtm |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes