ISSUE-709: Update Hugo to v0.120.0#719
Open
zxvcv wants to merge 1 commit intotektoncd:mainfrom
Open
Conversation
Fixes rendering emojis in code blocks. Update Hugo to never version. - Hugo updated to v0.120.0 - Dockerfile based on python:3.11.15 instead klakegg/hugo:0.107.0-ext-ubuntu
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rendering emojis in code blocks.
Update Hugo to never version.
Changes
So we need Hugo version >= v0.120.0 to fix the issue with rendering emojis in code blocks .
Originally Docker image was based on klakegg/hugo images based on ubuntu but the newest image is there for version 0.111.3
which is not enough to fix the problem.
Current official images for hugo are available as ghcr.io/gohugoio/hugo but those are based on alpine, unfortunately netlify requires Deno (Netlify Edge Functions) and Deno dont support Alpine Linux (musl libc) denoland/deno#3711.
So I tried to install everything from scratch on ubuntu based image.
This leads me to install newest hugo version (v0.159.0).
But this time Docsy v0.6.0 is not compatible with newest version of Hugo (highest verion hugo that supports Docsy 0.6.0 is v0.128.x)
Website with Hugo version v0.128.x has some bugs (Few sections disappeared on the left navigation bar) so at the end I leave version v0.120.0 that seems to work fine.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.