Skip to content

test: skip http2 tests older Node.js #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lamweili wants to merge 1 commit into
base: http2-warning
Choose a base branch
from
Open

test: skip http2 tests older Node.js #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,16 @@ var describeStatusMessage = !/statusMessage/.test(http.IncomingMessage.toString(
? describe.skip
: describe

var describeHttp2 = describe.skip
try {
var http2 = require('http2')
describeHttp2 = describe
} catch (err) {
if (err) {
console.log('http2 tests disabled.')
}
}

describe('finalhandler(req, res)', function () {
describe('headers', function () {
it('should ignore err.headers without status code', function (done) {
Expand Down Expand Up @@ -514,15 +524,8 @@ describe('finalhandler(req, res)', function () {
})
})

describe('HTTP2', function () {
describeHttp2('HTTP2', function () {
it('should not set statusMessage for HTTP2 response', function (done) {
var http2
try {
http2 = require('http2')
} catch (e) {
return done()
}

process.once('warning', function (warning) {
assert.fail(warning)
})
Expand Down