Dont panic!: General rework to remove all panic!, assert! & .unwrap() from library#56
Open
guilledk wants to merge 60 commits intotelosnetwork:masterfrom
Open
Dont panic!: General rework to remove all panic!, assert! & .unwrap() from library#56guilledk wants to merge 60 commits intotelosnetwork:masterfrom
panic!, assert! & .unwrap() from library#56guilledk wants to merge 60 commits intotelosnetwork:masterfrom
Conversation
added 24 commits
April 24, 2025 00:01
…ead, refine error macros
…aits like FromStr and TryFrom to instantiate the structs
…factor HasNameAndType into AbiTableView and make more complete
…king type to be [u8; 32]
added 5 commits
May 30, 2025 18:04
…ome clippy warnings
…sing the .to_string() auto generated by Display trait impl for all checksums
…w only .to_string() should be used which is implemented using Display trait
…m_bytes in favour of From<&[u8]> on checksum classes
…slice() & bring BlockId def from custom module to checksums module, define it using the macro
… be covering all builtin types
…n packing just use .into_inner()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTES:
v0.4.0of the library increased fromv0.3.1to indicate API breaking changesAPI Changes:
Packertrait'sunpack()return aResult<usize, PackerError>intead of justusizechainstuct constructors, implementFrom/TryFrom/FromStrtraits insteadDisplaytrait which automatically grantsto_stringfor chain structsAdditions:
FromStrmany integer types forNameFrom<u64>forName.to_string()toTimePoint&TimePointSecBlockTimestampwhich is the slot based time point secserdename serializers in order to be able to do ABI json dumpsShipABIwhich represents the ABI thatstate_history_pluginsends as first message representing the session typesPartialEqto authority structschainstructs fields public like inExtendedAsset,PackedTransaction&SignatureBinaryExtension's inner value publicDebugonChecksum512FromStrforPrivateKey