Skip to content

improve plugin loading logging#527

Merged
Alfro merged 1 commit intoteltek:masterfrom
ppettit:improve_plugin_loading_logging
May 18, 2017
Merged

improve plugin loading logging#527
Alfro merged 1 commit intoteltek:masterfrom
ppettit:improve_plugin_loading_logging

Conversation

@ppettit
Copy link
Collaborator

@ppettit ppettit commented May 17, 2017

just a small patch that changes no functionality, but i found it useful when writing plugins.

logs stack trace when something goes wrong inside the plugin
(very useful when developing). also logs whether the plugin is
internal or external when it loads, which helps understand which
version of a plugin is loading (if you have installed plugin with
pip as well as in the galicaster plugins directory for example).

logs stack trace when something goes wrong inside the plugin
(very useful when developing). also logs whether the plugin is
internal or external when it loads, which helps understand which
version of a plugin is loading (if you have installed plugin with
pip as well as in the galicaster plugins directory for example).
@ppettit
Copy link
Collaborator Author

ppettit commented May 17, 2017

actually, just thinking maybe the plugin loader should actually try loading external plugins first, so that internal ones can be overridden? happy to change that if it is a good idea.

@Alfro
Copy link
Contributor

Alfro commented May 18, 2017

Seems okay. Thanks!

@Alfro Alfro merged commit 3386abe into teltek:master May 18, 2017
@Alfro
Copy link
Contributor

Alfro commented May 18, 2017

I am not sure about overriding internal plugins with external ones though. What would the advantage be of overriding internal plugins vs directly modifying their code?

@ppettit
Copy link
Collaborator Author

ppettit commented May 18, 2017

thought maybe it would be easier to install an updated or modified version of a plugin that is part of galicaster. but actually i guess you could just make a copy and rename it if needed.

was just a thought but i think you are right it is not necessary!

thanks!

@ppettit ppettit deleted the improve_plugin_loading_logging branch May 18, 2017 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants