Upgraded libraries, wrote concise step-by-step instructions, and removed unnecessary comments#41
Merged
Conversation
lennessyy
approved these changes
Aug 27, 2025
| <!-- | ||
| CAUTION: Temporal applications require Java 8 (1.8) compiler source | ||
| and target at the time this material was developed. | ||
| CAUTION: Temporal applications require Java 8 (1.8) or higher. |
There was a problem hiding this comment.
I feel like this warning may be best if it is put in the README as a prerequisite instead? Though I don't know the habits of Java developers or if they are likely to be checking the pom.xml for warnings like this. Feel free to disregard if it feels redundant.
Contributor
Author
There was a problem hiding this comment.
@lennessyy You make a good point and I appreciate your attention to detail.
The requirement to have Java 8 or higher is documented in the README for the Java SDK (https://github.com/temporalio/sdk-java/tree/master?tab=readme-ov-file#supported-java-runtimes). It's also in the prose for the "Set up a local development environment for Temporal and Java" tutorial that precedes this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
I upgraded the Temporal SDK and other library dependencies to the latest stable versions. I also revised the README to include concise step-by-step instructions (and downplayed the use of
makeas this is not a standard tool for Java developers and those not using UNIX systems are unlikely to have it installed). Finally, I reduced non-essential comments, such as the version numbers of libraries that this was tested with, since that's already clear from the versions in thepom.xmlfile.Why?
To make the repository more up-to-date and easier to use.
Checklist
N/A
I manually ran the steps in the README and also ran
mvn testto verify that all automated tests pass.No