External workflow signal from a workflow code throws incorrect exceptions

[Spikhalskiy]

Actual Behavior

fun signalWorkflow(workflowId: String, signalName: String, vararg args: Any) {
        try {
            Workflow.newUntypedExternalWorkflowStub(workflowId).signal(signalName, args)
        } catch (ex: ApplicationFailure) {
            if (ex.type == "SIGNAL_EXTERNAL_WORKFLOW_EXECUTION_FAILED_CAUSE_EXTERNAL_WORKFLOW_EXECUTION_NOT_FOUND") {
                logger.info {
                    it.message("Workflow not found while attempting to send signal to it.")
                        .value("workflowId", workflowId).value("signal", signalName)
                }
            }
        }
    }

The code above shouldn't work and ApplicationFailure is an incorrect exception to be thrown here.

Additional context

There is already an exception for this situation: SignalExternalWorkflowException that is currently not created anywhere.

There is also a todo to implement exactly this that never was done:

sdk-java/temporal-sdk/src/main/java/io/temporal/internal/statemachines/SignalExternalStateMachine.java

Line 152 in 37a0e46

// TODO(maxim): Special failure type

Another alternative exception to consider here may be WorkflowNotFoundException

[pragnareddye]

@Spikhalskiy @Quinn-With-Two-Ns This would be a backwards incompatible change for users who have implemented their code by catching ApplicationFailure type right?