TestWorkflowRule that we provide to our users right now enforces 10 seconds timeout by default.
There is a lot of ways provided by JUnit to enforce test timeouts and that can be used by our users if they need this and our test rule shouldn't be responsible for such basic test framework functionality.
Worse is that by providing 10 seconds by default, we create a productivity problem for our users because they need to figure out how to disable this never-asked-about functionality.
We want to have this enabled and enforced across Temporal tests though and I propose to:
- Move existing global timeout implementation into Temporal internal
SDKTestWorkflowRule.
- Remove logic of TestWorkflowRule that enforces timeout.
- Mark timeout functionality of public TestWorkflowRule as deprecated and remove in the release after the next one.
TestWorkflowRulethat we provide to our users right now enforces 10 seconds timeout by default.There is a lot of ways provided by JUnit to enforce test timeouts and that can be used by our users if they need this and our test rule shouldn't be responsible for such basic test framework functionality.
Worse is that by providing 10 seconds by default, we create a productivity problem for our users because they need to figure out how to disable this never-asked-about functionality.
We want to have this enabled and enforced across Temporal tests though and I propose to:
SDKTestWorkflowRule.