S63: POST /issues honors labels/assignees/milestone (B3)#304
Merged
Conversation
espadonne
force-pushed
the
s63/issue-create-fields
branch
from
4bdc6f0 to
07df9c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes B-audit finding B3: POST /api/v1/repos/{o}/{r}/issues was dropping
labels[],assignees[], andmilestoneeven when the CLI sent them, forcing a follow-up PATCH for any non-trivial issue create.issueCreateRequestwithlabels,assignees,milestone.issues.Create()succeeds, apply each via the same helpers the PATCH path uses (ApplyLabels,AssignUser,AssignMilestone).GetIssueByIDso the response reflects the final state.POST /repos/{}/{}/issuesbehavior. PATCH-time gates (ActionIssueLabel,ActionIssueAssign) still apply on later edits.Test plan
TestIssues_CreateWithLabelsAssigneesMilestone— happy path, asserts response labels + DB-side assignee row + DB-side milestone id.TestIssues_CreateUnknownLabelRejected— 422 on bad label name + no issue inserted.TestIssuessuite still green against the integration DB.golangci-lint run ./internal/web/handlers/api/...— 0 issues.