Expose more hyperparameters to FLAGS#595
Closed
djdongjin wants to merge 2 commits intotensorflow:masterfrom
djdongjin:args
Closed
Expose more hyperparameters to FLAGS#595djdongjin wants to merge 2 commits intotensorflow:masterfrom djdongjin:args
djdongjin wants to merge 2 commits intotensorflow:masterfrom
djdongjin:args
Conversation
added 2 commits
May 18, 2020 22:38
Collaborator
|
Thanks this looks great! I've sent this through our internal review system and will close the PR once it's been submitted |
kempy
pushed a commit
that referenced
this pull request
Jun 10, 2020
#595 PiperOrigin-RevId: 315766834
Collaborator
|
Thanks! Your contribution was merged into master in 7708d8b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TODOs in the files to expose hyperparams to FLAGS such that users can change them if needed. The default values are the same.