Add publish-npm, make-version, tag-version scripts to models.#369
Merged
Add publish-npm, make-version, tag-version scripts to models.#369
Conversation
dsmilkov
approved these changes
Dec 6, 2019
Contributor
dsmilkov
left a comment
dsmilkov
left a comment
There was a problem hiding this comment.
Reviewed 120 of 120 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @nsthorat)
scripts/publish-npm.sh, line 17 at r1 (raw file):
# ============================================================================= # Before you run this script, run `yarn release` and commit the PRs.
update comment
nsthorat
commented
Dec 6, 2019
Author
nsthorat
left a comment
nsthorat
left a comment
There was a problem hiding this comment.
Reviewable status:
scripts/publish-npm.sh, line 17 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
update comment
done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds versions and unit tests to each model. We're also bumping the patch version for each of these so I can publish a new version, tag them, and then have them sync back to google.
This change is