[webgpu] Add support for SparseToDense#5629
Merged
qjia7 merged 7 commits intotensorflow:masterfrom Sep 24, 2021
Merged
Conversation
haoyunfeix
force-pushed
the
webgpu_feature_s2d
branch
2 times, most recently
from
64ebc11 to
a2ed810
Compare
Contributor
Author
qjia7
reviewed
Sep 22, 2021
| size: number; | ||
| useWgsl: boolean; | ||
| sliceDim: number; | ||
| shape: number[]; |
Contributor
There was a problem hiding this comment.
nit: sliceDim/shape are never used members?
qjia7
approved these changes
Sep 23, 2021
Contributor
qjia7
left a comment
qjia7
left a comment
There was a problem hiding this comment.
LGTM. Please resolve the conflicts.
| uniforms: string; | ||
| uniformsWgsl: string; | ||
| outputShape: number[]; | ||
| userCode: string; |
Contributor
There was a problem hiding this comment.
nit: userCode is not needed.
pyu10055
approved these changes
Sep 23, 2021
Collaborator
pyu10055
left a comment
pyu10055
left a comment
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 2 of 1 approvals obtained (waiting on @haoyunfeix and @qjia7)
haoyunfeix
force-pushed
the
webgpu_feature_s2d
branch
from
46ea9d8 to
f48a9f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FEATURE
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is