Skip to content

Promote google_essential_contacts_contact to GA#162

Merged
modular-magician merged 1 commit intoterraform-google-modules:masterfrom
modular-magician:downstream-pr-77e38d4dca650e0a85b4fc2af8555750f6d83890
Aug 16, 2021
Merged

Promote google_essential_contacts_contact to GA#162
modular-magician merged 1 commit intoterraform-google-modules:masterfrom
modular-magician:downstream-pr-77e38d4dca650e0a85b4fc2af8555750f6d83890

Conversation

@modular-magician
Copy link
Copy Markdown
Collaborator

Fixes: hashicorp/terraform-provider-google#9783

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

essentialcontacts: promoted `google_essential_contacts_contact` to GA

Derived from GoogleCloudPlatform/magic-modules#5097

* promote resource

Co-authored-by: upodroid <cy@borg.dev>

* fix import

* remove deprecated api and contact_id

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 6983d7d into terraform-google-modules:master Aug 16, 2021
@modular-magician modular-magician deleted the downstream-pr-77e38d4dca650e0a85b4fc2af8555750f6d83890 branch November 18, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix import for google_essential_contacts_contact

1 participant