Skip to content

Add nil check to recurring_schedule in google_os_config_patch_deployment#86

Merged
modular-magician merged 1 commit intoterraform-google-modules:masterfrom
modular-magician:downstream-pr-1319e3994b555da2ba7b38838ef35ade57efe2f8
Sep 14, 2020
Merged

Add nil check to recurring_schedule in google_os_config_patch_deployment#86
modular-magician merged 1 commit intoterraform-google-modules:masterfrom
modular-magician:downstream-pr-1319e3994b555da2ba7b38838ef35ade57efe2f8

Conversation

@modular-magician
Copy link
Copy Markdown
Collaborator

Fixes hashicorp/terraform-provider-google#7229

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

osconfig: fixed a potential crash in `google_os_config_patch_deployment` due to an unchecked nil value in `recurring_schedule`

Derived from GoogleCloudPlatform/magic-modules#3974

…ent (#3974)

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit fc21881 into terraform-google-modules:master Sep 14, 2020
@modular-magician modular-magician deleted the downstream-pr-1319e3994b555da2ba7b38838ef35ade57efe2f8 branch November 18, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

one_time_schedule in google_os_config_patch_deployment crashes

1 participant