Exclude generated build output from npm package#789
Merged
scarlac merged 1 commit intoMay 5, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the library’s npm packaging rules to avoid shipping generated build artifacts (notably android/build/generated) that can conflict with the consuming app’s React Native codegen output (e.g., RN 0.83+), causing Android C++ compile failures.
Changes:
- Add a
prepackhook to delete local generated build output before packing/publishing. - Remove top-level
buildfrom the publishedfileswhitelist and explicitly excludeandroid/buildfrom the package contents.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
scarlac
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #769
LONG VERSION
CameraKit ships a dirty android/build folder in npm.
That folder contains old generated C++ files.
When our app builds:
android/build/generated/...NativeCameraKitSpecJSI-generated.cpp)NativeCameraKitModuleCxxSpecJSISHORT VERSION
RNCK ships old generated files.
RN 0.83 generates new files with new conventions.
Old and new files get mixed.
C++ compiler explodes.