Add the ability to specify an image's platform.#7313
Merged
Conversation
It's possible to specify the platform for a container by using `GenericContainer#withCreateContainerCmdModifier`. However, it's not possible to do the same when creating an image, and so it's not possible to both create and test an image for a platform. This adds `ImageFromDockerfile#withBuildImageCmdModifier` which makes this possible.
Member
|
Thanks for your contribution, @shawjef3 ! |
fokion
pushed a commit
to fokion/testcontainers-java
that referenced
this pull request
Jan 18, 2025
`withBuildImageCmdModifier` allows to customize the `BuildImageCmd` created with `ImageFromDockerfile`. --------- Co-authored-by: Eddú Meléndez <eddu.melendez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible to specify the platform for a container by using
GenericContainer#withCreateContainerCmdModifier. However, it's not possible to do the same when creating an image, and so it's not possible to both create and test an image for a platform.This adds
ImageFromDockerfile#withBuildImageCmdModifierwhich makes this possible.#7312