fix(k3s): use with_tmpfs_mount to avoid duplicate tmpfs kwarg#1034
Open
Tranquility2 wants to merge 1 commit into
Open
fix(k3s): use with_tmpfs_mount to avoid duplicate tmpfs kwarg#1034Tranquility2 wants to merge 1 commit into
Tranquility2 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1034 +/- ##
=======================================
Coverage 83.29% 83.29%
=======================================
Files 16 16
Lines 1754 1754
Branches 193 193
=======================================
Hits 1461 1461
Misses 236 236
Partials 57 57 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
K3SContainer.__init__configures tmpfs mounts viawith_kwargs:Since #978,
DockerContainer.start()also passestmpfs=self.tmpfsexplicitly todocker_client.create(), while still spreading**self._kwargs. This causes a duplicate-keyword error on every K3S container start:CI evidence: every
test (3.10|3.13|3.14, k3s)job fails with this error.Fix
Migrate to the dedicated
with_tmpfs_mount()API introduced in #978, leaving onlyprivileged=Trueinwith_kwargs.Verification
uv run pytest -q modules/k3s/tests/test_k3s.pyno longer raises theTypeError(container starts successfully; remaining test progression depends on CI environment as before).