Skip to content

test(milvus): cast exposed_port to str for substring assert#1035

Open
Tranquility2 wants to merge 1 commit into
mainfrom
fix/milvus-test-port-type
Open

test(milvus): cast exposed_port to str for substring assert#1035
Tranquility2 wants to merge 1 commit into
mainfrom
fix/milvus-test-port-type

Conversation

@Tranquility2
Copy link
Copy Markdown
Contributor

Problem

test_run_milvus_success asserts:

assert url and exposed_port in url

get_exposed_port() returns int, so the in check against a string url raises:

TypeError: 'in <string>' requires string as left operand, not int

CI evidence: test (3.10|3.13|3.14, milvus) jobs fail this assertion for both v2.4.0 and v2.4.4.

Fix

Cast exposed_port to str before the substring check.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.12%. Comparing base (be4c857) to head (a7df3d7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
- Coverage   83.29%   83.12%   -0.18%     
==========================================
  Files          16       16              
  Lines        1754     1754              
  Branches      193      193              
==========================================
- Hits         1461     1458       -3     
- Misses        236      240       +4     
+ Partials       57       56       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant